fix: improve screenshot reliability with page readiness check#4
Open
RapierCraft wants to merge 1 commit intomainfrom
Open
fix: improve screenshot reliability with page readiness check#4RapierCraft wants to merge 1 commit intomainfrom
RapierCraft wants to merge 1 commit intomainfrom
Conversation
- Wait for document.readyState === 'complete' before capturing - Add small delay after load to ensure rendering is complete - Validate result data and throw descriptive error if empty - Add captureBeyondViewport: false for consistent behavior Tested locally: - Screenshot captured successfully (55KB, 202ms) - Page readiness check works correctly - Empty data validation working Fixes #2
96f5a0b to
fc92f4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comet_screenshotreliability by waiting for page to be ready before capturingProblem
Users reported that
comet_screenshotreturns empty content without any error message (#2).Root Cause Analysis
The original implementation had several issues:
withAutoReconnectwrapper missing)Solution
Changes
withAutoReconnectwrapper for connection resiliencedocument.readyState === 'complete')captureBeyondViewport: falsefor consistent behaviorTest Plan
Fixes #2