Draft
Conversation
Rangi42
requested changes
Mar 1, 2026
| const POKEDEX_SHOW_6 ; 55 | ||
| const POKEDEX_SHOW_7 ; 56 | ||
| const POKEDEX_SHOW_8 ; 57 | ||
| const RADIO_SCROLL ; 55 |
| db MUSIC_POKE_FLUTE_CHANNEL | ||
| db MUSIC_RUINS_OF_ALPH_RADIO | ||
| db MUSIC_LAKE_OF_RAGE_ROCKET_RADIO | ||
| db MUSIC_ROUTE_30 |
Owner
There was a problem hiding this comment.
Since this doesn't have an obvious name, can you add comments on each line with the channel constants?
|
|
||
| SECTION "_WC_IntroText2", ROMX | ||
| _WC_IntroText2:: | ||
| line "Pokécast Inst." |
|
|
||
| SECTION "_WC_Greet1", ROMX | ||
| _WC_Greet1:: | ||
| line "DJ Zephyr here!" |
Owner
There was a problem hiding this comment.
Let's be sure to add Zephyr in the radio tower!
| push de | ||
| ld bc, SCREEN_WIDTH * 2 | ||
| rst CopyBytes | ||
| ; Copy up to SCREEN_WIDTH * 2 bytes, stopping before $8000 bank boundary. |
Owner
There was a problem hiding this comment.
Please add an explanation of why a copy would ever potentially overflow past the bank if not cut off? Why wouldn't the length already keep it contained within the bank?
|
|
||
| .default_map | ||
| ; Uninitialized overcast slot — use New Bark Town as fallback | ||
| ld b, GROUP_NEW_BARK_TOWN |
| ld c, MAP_NEW_BARK_TOWN | ||
| jr .normal_group | ||
|
|
||
| .WeatherStrings: |
| db "blossoms!@" | ||
|
|
||
| ; For aliased overcast areas, map to the first real map in each area | ||
| .AliasToMap: |
Owner
There was a problem hiding this comment.
This is map data so goes in data/maps/.
| call Random | ||
| and 1 | ||
| jr z, .snowtop | ||
| ; Rugged Road - always has sandstorms |
| pop hl | ||
| ; Copy weather string to wStringBuffer2 | ||
| ld de, wStringBuffer2 | ||
| .copy_ws: |
Owner
There was a problem hiding this comment.
I'm sure there's a routine in home/ for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the weather radio. This is still a work in progress.. but feel free to preview it.
Right now you should free the slowpokes first in AzaleaTown.