Add Eusine rematch and rework event handling in Eusine#1392
Draft
Add Eusine rematch and rework event handling in Eusine#1392
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a post–Ho-Oh rematch for Eusine and reworks how Eusine’s quest progression is tracked across Tin Tower and Eusine’s House by introducing new event flags and adjusting respawn behavior.
Changes:
- Add a new quest-completion flag (
EVENT_EUSINE_SAW_HO_OH) and update Tin Tower / Eusine’s House scripts to use it. - Add a new rematch trainer entry (
EUSINE_2) and a new “beaten” event flag (EVENT_BEAT_EUSINE_2) to gate the rematch. - Adjust Ho-Oh respawn handling to no longer reset Eusine’s house presence flag.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| maps/TinTower1F.asm | Gates Eusine’s post–Ho-Oh appearance and sets new quest-completion flags after the post-fight scene. |
| maps/EusinesHouse.asm | Adds post–Ho-Oh dialogue + optional rematch flow; reworks grandpa’s reward logic around the new quest flag. |
| engine/events/specials.asm | Removes resetting Eusine’s house event during Ho-Oh respawn logic. |
| data/trainers/parties.asm | Adds Eusine’s rematch trainer party definition. |
| constants/trainer_constants.asm | Adds the EUSINE_2 trainer constant. |
| constants/event_flags.asm | Adds EVENT_BEAT_EUSINE_2 and EVENT_EUSINE_SAW_HO_OH. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the reworked flow here:
Mermaid Diagram
Note: Have not tested in game yet.