Fix Professor Elm duplicate dialogue after showing hatched Togepi#1317
Draft
Fix Professor Elm duplicate dialogue after showing hatched Togepi#1317
Conversation
Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix dialogue inconsistency after Togepi egg hatching
Fix Professor Elm duplicate dialogue after showing hatched Togepi
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After showing Professor Elm the hatched Togepi, receiving the Odd Souvenir, and completing the battle dialogue, Elm incorrectly repeats "I thought the Egg hatched. Where is the Pokémon?"
Changes
scall ElmEggHatchedScripttosjumpfwd ElmEggHatchedScriptjumptext ElmThoughtEggHatchedTextTechnical Details
The script used
scall(subroutine call) when it should usesjumpfwd(forward jump). While all successful dialogue paths properly end the conversation with commands likeendtextorjumptextfaceplayer, the script engine would return to thejumptextstatement after thescall, displaying the erroneous message.The "Where is the Pokémon?" message remains accessible via
ElmCheckGotEggAgainfor the edge case where the player was told about hatching but no longer has Togepi/Togetic/Togekiss.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.