Skip to content

Fix Professor Elm duplicate dialogue after showing hatched Togepi#1317

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-professor-elm-dialogue
Draft

Fix Professor Elm duplicate dialogue after showing hatched Togepi#1317
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-professor-elm-dialogue

Conversation

Copy link
Contributor

Copilot AI commented Dec 14, 2025

After showing Professor Elm the hatched Togepi, receiving the Odd Souvenir, and completing the battle dialogue, Elm incorrectly repeats "I thought the Egg hatched. Where is the Pokémon?"

Changes

  • maps/ElmsLab.asm:156: Changed scall ElmEggHatchedScript to sjumpfwd ElmEggHatchedScript
  • maps/ElmsLab.asm:157-159: Removed obsolete comment and jumptext ElmThoughtEggHatchedText

Technical Details

The script used scall (subroutine call) when it should use sjumpfwd (forward jump). While all successful dialogue paths properly end the conversation with commands like endtext or jumptextfaceplayer, the script engine would return to the jumptext statement after the scall, displaying the erroneous message.

  checkevent EVENT_TOLD_ELM_ABOUT_TOGEPI_OVER_THE_PHONE
  iffalsefwd ElmCheckTogepiEgg
- scall ElmEggHatchedScript
- ; need to reopen text boxes since ElmCheckGotEggAgain's
- ; jumpopenedtext will close them.
- jumptext ElmThoughtEggHatchedText
+ sjumpfwd ElmEggHatchedScript

The "Where is the Pokémon?" message remains accessible via ElmCheckGotEggAgain for the edge case where the player was told about hatching but no longer has Togepi/Togetic/Togekiss.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Inconsistency in Professor Elm dialogue after egg hatched</issue_title>
<issue_description>When talking to Professor Elm after the Togepi egg hatched, he will talk about the egg hatching and give you the Odd Souvenir.
Then, he asks for a battle. Whether or not you accept or deny, at the end of the conversation, Elm will say:

[player name]? I thought 
the Egg hatched.

Where is the
Pokémon?

This part of the conversation shouldn't occur since you already talked about the egg hatching.</issue_description>

<agent_instructions>Describe the inconsistencies in Professor Elm's dialogue and then fix the problem as described in the issue.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dialogue inconsistency after Togepi egg hatching Fix Professor Elm duplicate dialogue after showing hatched Togepi Dec 14, 2025
Copilot AI requested a review from vulcandth December 14, 2025 16:29
@vulcandth vulcandth added this to the 3.3.0 milestone Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency in Professor Elm dialogue after egg hatched

2 participants