Moves Batch

[aubsgp]

Added: Wake-Up Slap, Smelling Salts, Strange Steam, Mud Sport, Water Sport, Magic Room, and Wonder Room.

Some other miscellaneous edits, such as:

• Combined Trick Room and Gravity into one byte
• Converted some constants into static variables (bitmasks mainly)
• Added a general-purpose DecrementCounter to save space on end-of-turn nybble decrements (with an associated message if they hit 0)

[emilyploszaj]

Lots of files are missing trailing newline. Left comments on specific nitpicks, but there were no major logical problems.

[FredrIQ]

Thanks for the PR!

I will take a closer look at the code shortly. While it looks fine logically, there are some behaviour I am unsure about whether it matches mainline or not (particularly around Wonder Room) which I'll have to look over.

One thing I'm wondering is: what made you choose these particular moves to implement? They are for the most part non-controversial so I see little issue in adding them. I find Mud/Water Sport to be utterly pointless moves (challenge: come up with a case where Mud Sport is legitimately useful), but I'm not outright against adding them. But there are moves in mainline that we don't really want to add, such as Stealth Rock, which is why I'm asking how you decided what moves to add.

[aubsgp]

Yeah, Wonder Room is really weird, and it took me a while to run through all the behavior on Showdown and the like, wouldn't be surprised if I missed something. Gotta say, I was not expecting to learn that Download ignores it!

As for how I chose these moves -- I was sort of trying to gain experience, mostly. There are some fun niche uses of Mud/Water Sport in harder romhacks, where the player doesn't get tools like Rain Dance, but they are mostly useless moves even there...I just like them, I guess. :)

(I did also double-check with Emi that you would in fact want these moves; she's mentioned the stealth rock thing to me before.)

Thanks for taking the time to look this over!

[rofl0r]

checked in by mistake ?

[aubsgp]

Yep, sorry.

[aubsgp]

Mud Sport, Water Sport, and Smelling Salts have been all removed, as requested. Let me know if you'd like any additional changes.