Skip to content

Check query object before $eq in update#12

Open
cayasso wants to merge 7 commits intoRangerMauve:defaultfrom
cayasso:default
Open

Check query object before $eq in update#12
cayasso wants to merge 7 commits intoRangerMauve:defaultfrom
cayasso:default

Conversation

@cayasso
Copy link
Copy Markdown

@cayasso cayasso commented Feb 11, 2023

This fails without the first commit fix:

await db.update({ id: '1' }, { $inc: { seq: 1 } })

@cayasso cayasso changed the title Check query object before checking for $eq on update Check query object before $eq in update Feb 11, 2023
@cayasso
Copy link
Copy Markdown
Author

cayasso commented Feb 11, 2023

Hey, as you can see most of the changes added are small changes, the only important change that can be a breaking change is the BSON upgrade which now exports ObjectId instead of ObjectID.
Thank you for this module!

@RangerMauve
Copy link
Copy Markdown
Owner

Are the extra changes with the sub-encoder and updated bson module strictly necessary? I notice there is also an empty watch method that got added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants