Skip to content

Conversation

@mjwelchphd
Copy link

Updated BlueForm to:

  • Add support for HTML5 elements.
  • Add a 'arrangements' argument to the form_for which can be :arrangements=>:paragraph and the label + input will be wrapped in <p>...</p> as before; or:arrangements=>:tablewill wrap in a table format, and:arrangements=>:none` will omit the wrapping.
  • Added a tag method where all the actual generation takes place. This was needed to implement the arrangements.
  • All the tag-named methods from the previous versions are now implemented by calling tag with their args and opts. This implements DRY.
  • Updated the specs to add new tests for the tag method.
  • Updated lib/ramaze/gestalt.rb to hardcode the table tags. This was needed for the new BlueForm modifications.

mjwelchphd and others added 5 commits May 12, 2016 01:34
Created a new "tag" method which creates all the tags. The earlier methods, such as input_text, et.al., now just call "tag". Also added an "arrangement" option to allow the label-control fields to be wrapped in paragraphs (the default), or a table for nicer formatting, or no wrapping at all.
…eal methods in the code for the BlueForm HTML5 changes to work.
…w BlueForm updates.

Numbered the tests so I could figure out which was which. The tests below 100 are the original tests, and the ones over 100 are the new tests. If all the tests under 100 pass, the new BlueForm is completely backwards compatible.
@mjwelchphd mjwelchphd closed this May 16, 2016
@manveru manveru reopened this May 16, 2016
@manveru
Copy link
Member

manveru commented May 16, 2016

This looks good, I'll just have to tweak the version a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants