Skip to content

fix: implement NTFS hardlink fallback and updated warnings #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
unpetrifiedstone2005 wants to merge 1 commit into from
+9 −3
Closed

fix: implement NTFS hardlink fallback and updated warnings #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/dedupe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ pub fn replace_with_link(
Ok(Some(LinkType::Reflink))
}
Err(_) => {
// NTFS or non-CoW filesystems fail here.
// We must remove the temp file before trying a hardlink.
if temp.exists() {
let _ = std::fs::remove_file(&temp);
}
Expand All @@ -88,8 +90,9 @@ pub fn replace_with_link(

Ok(Some(LinkType::HardLink))
} else {
// Modified error message to specifically mention NTFS/WSL
anyhow::bail!(
"reflink not supported on this filesystem and --allow-unsafe-hardlinks not specified"
"reflink not supported (common on NTFS/WSL) and --allow-unsafe-hardlinks not specified"
)
}
}
Expand Down
7 changes: 5 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,14 @@ fn dedupe_groups(
if !reflink_warning_shown {
println!("\n{}", "━".repeat(80).yellow());
println!(
"{} Filesystem Does Not Support Copy-on-Write Reflinks",
"{} Filesystem (NTFS/WSL) Does Not Support Copy-on-Write Reflinks",
"[WARNING]".bold().yellow()
);
println!("{}", "━".repeat(80).yellow());
println!("\nYour filesystem does not support CoW (Copy-on-Write) reflinks.");
println!(
"This is expected on NTFS drives or when running via WSL on a Windows host."
);
println!(
"Reflinks allow files to share disk space while remaining independent copies."
);
Expand All @@ -266,7 +269,7 @@ fn dedupe_groups(
"Do nothing".green()
);
println!(
" 2. {} - Enables deduplication with shared metadata",
" 2. {} - Enables deduplication via hard links (Required for NTFS)",
"Add --allow-unsafe-hardlinks".yellow()
);
println!(
Expand Down
Loading