Refactor nMars output parsing for better robustness#340
Conversation
The previous implementation of `parse_nmars_output` relied on hardcoded indices, which caused crashes or failed to parse scores if warrior metadata (names or authors) contained spaces. Changes: - Replaced index-based parsing with a dynamic search for the 'scores' keyword. - Added a try-except block to handle malformed lines gracefully without interrupting the evolution loop. - Updated `tests/test_battle_logic.py` to reflect the improved parsing logic and added new test cases for spaces in names and minimal output formats. - Removed redundant line counting and verbose output. Co-authored-by: RainRat <20098977+RainRat@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Improved the robustness of
parse_nmars_outputinevolverstage.pyby dynamically locating the 'scores' keyword and the warrior ID. This fix prevents crashes when warriors have names with spaces and allows for more flexible output formats from the nMars simulator. Verified with existing and new test cases.PR created automatically by Jules for task 7885652218906262024 started by @RainRat