Unify nMars command construction and resolve duplication#316
Unify nMars command construction and resolve duplication#316
Conversation
- Centralized nMars executable resolution in `_get_nmars_cmd()`. - Enhanced `construct_battle_command` with optional parameter overrides. - Refactored `run_nmars_command` to delegate to `construct_battle_command`. - Updated `validate_configuration` to use the new helper. - Verified all 134 tests pass. Co-authored-by: RainRat <20098977+RainRat@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This PR improves code quality by resolving multiple instances of duplication related to nMars command-line generation. It introduces a private helper function for platform-specific executable resolution and enhances the main command construction utility to handle both default and overridden parameters. These changes are non-breaking and maintain existing external behavior while improving maintainability and reducing the likelihood of future bugs.
PR created automatically by Jules for task 1221809078282384578 started by @RainRat