Skip to content

Fix Janggi rank notation and add regression test#11

Draft
RainRat wants to merge 1 commit intomasterfrom
codex/adjust-rank-in-notation_janggi-branch
Draft

Fix Janggi rank notation and add regression test#11
RainRat wants to merge 1 commit intomasterfrom
codex/adjust-rank-in-notation_janggi-branch

Conversation

@RainRat
Copy link
Owner

@RainRat RainRat commented Sep 20, 2025

Summary

  • adjust the Janggi rank formatter to keep the raw rank value and map the back rank to 10 instead of 0
  • update the Janggi SAN test to expect the corrected coordinate and assert the notation includes "10"

Testing

  • python3 test.py (fails: ModuleNotFoundError: No module named 'pyffish')

https://chatgpt.com/codex/tasks/task_e_68ce1a5b7c048330a1675c054445f7ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant