Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been working recently with a Waveshare ESP32-S3-Touch-LCD-7 which uses a CH422 IO chip (datasheet) for some of its core functions.
So I've had a go at adding support for it to the crate.
It's a bit a strange chip:
my work in progress implementation just supports the 8 io pins. It uses type state for switch between the two modes (input and output) but I'm not sure this is the right solution for a couple of reasons.
let mut io: port_expander::Ch422<RefCell<_>> = port_expander::Ch422::new(i2c).enable_output().unwrap();enable_outputmethod is fallible and will drop the Port if it returns an ErrBut using typestate means that when we call
split, thePins have the correct mode.