Feature/219 recover from faulted state #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erenceState CommunicationState.Faulted. Raised WriteDebug to WriteWarning to see if Faulted event handler is even triggered for for example private void BackgroundTaskClientChannelFaulted(object sender, EventArgs e)
…r) EventHandler
There was a problem hiding this comment.
Pull Request Overview
This PR implements recovery from faulted WCF communication states by enhancing channel state handling and exception management across the ISHRemote library. The changes enable automatic recovery when WCF channels enter faulted, closing, or closed states.
Key Changes:
- Extended WCF channel state detection to handle
ClosingandClosedstates in addition toFaulted - Added comprehensive exception handling for
TimeoutException,CommunicationException, andAggregateExceptionacross all cmdlets - Modified faulted channel event handlers to log at verbose level instead of debug
- Set disposed connection references to null in
IshSession.Dispose()
Reviewed Changes
Copilot reviewed 90 out of 90 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| IshSession.cs | Sets connection references to null after disposal for proper cleanup |
| InfoShareWcfSoapWithOpenIdConnectConnection.cs | Extends channel state checks and changes fault handler logging to verbose level |
| InfoShareOpenApiWithOpenIdConnectConnection.cs | Comments out OpenAPI client disposal (marked as TODO) |
| Multiple Cmdlet files | Adds standardized exception handling for timeout, communication, and aggregate exceptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Source/ISHRemote/Trisoft.ISHRemote/Cmdlets/Baseline/RemoveIshBaselineItem.cs
Show resolved
Hide resolved
Source/ISHRemote/Trisoft.ISHRemote/Cmdlets/Baseline/GetIshBaselineItem.cs
Show resolved
Hide resolved
Source/ISHRemote/Trisoft.ISHRemote/Connection/InfoShareWcfSoapWithOpenIdConnectConnection.cs
Show resolved
Hide resolved
mo2mensalem
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.