Skip to content

Conversation

@Yunusbcr
Copy link
Contributor

According to documentation QwtPlotCurve::Dots, "FASTER"

So, QwtPlotCurve::Dots added as a curve style option to produce scatter plot in oscilloscope

@fusge fusge self-assigned this Feb 11, 2025
@fusge fusge changed the base branch from master to dev February 14, 2025 12:26
@fusge fusge added the upgrades label Feb 26, 2025
@fusge
Copy link
Contributor

fusge commented Mar 1, 2025

Thanks for submitting this. A quick visual test shows that changing the line style does not take effect in the oscilloscope. Can you add logic to this so that users are able to use the other styles if they wish? A good place to start is in the scope.hpp/scope.cpp file where we implement pen style allowed types, as well as oscilloscope.cpp where we hook these style changes to qt events. Perhaps reusing those and replacing Qt::PenStyle with qwtcurvestyle?

@Yunusbcr
Copy link
Contributor Author

Yunusbcr commented Mar 6, 2025

This behavior is expected and desired. Line style is effective if only curve style chosen as "lines". If curve style is "dots", there will be no line to have style, basically all data points are just dots(scatter plot). I can grey out the line style drop-down menu when dots is chosen, if that is what you want?

@fusge fusge merged commit a86726b into RTXI:dev Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants