STYLE: Change vector to point when possible #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRit
requested changes
Nov 7, 2025
Collaborator
SimonRit
left a comment
SimonRit
left a comment
There was a problem hiding this comment.
We should also add a note to the transition page
| Corner2[2] = this->GetInput(0)->GetOrigin()[2] + | ||
| this->GetInput(0)->GetLargestPossibleRegion().GetSize()[2] * this->GetInput(0)->GetSpacing()[2]; | ||
| itk::Point<double, 3> Corner1, Corner2; | ||
| Corner1 = itk::MakePoint( |
Collaborator
|
@acoussat Can you please check that this does not break your wrapping of |
Collaborator
|
According to the CI, |
Collaborator
|
I guess not, thanks! |
Collaborator
Author
|
We should document the change of API in migration guide. |
axel-grc
force-pushed
the
PointType
branch
2 times, most recently
from
ca3c6df to
498fc59
Compare
axel-grc
commented
Dec 19, 2025
| { | ||
| typename InputRegionIterator::PointType pixelPosition = itIn->GetPixelPosition(); | ||
| typename InputRegionIterator::PointType dirVox = -itIn->GetSourceToPixel(); | ||
| stepMM.Fill(0.); |
Collaborator
Author
There was a problem hiding this comment.
This seems to fix the failing test that occurred because of pixelPosition that was corrected to stepMM line 422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #820