ENH: Add CudaSquareImageFilter wrap file #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRit
requested changes
Nov 24, 2025
Collaborator
SimonRit
left a comment
SimonRit
left a comment
There was a problem hiding this comment.
Thanks. There seems to be issue reported by the CI, can you address them? E.g., https://github.com/RTKConsortium/ITKCudaCommon/pull/89/checks#step:5:731. Regarding your question, yes, I think it can be wrapped for all types wrapped for itk::CudaImage. We could possibly implement a macro to simplify this a bit.
axel-grc
force-pushed
the
linter
branch
2 times, most recently
from
5bf90a4 to
5c4e247
Compare
axel-grc
force-pushed
the
linter
branch
6 times, most recently
from
0fe4158 to
0ea19ae
Compare
axel-grc
force-pushed
the
linter
branch
2 times, most recently
from
baeed30 to
7e4e8e8
Compare
axel-grc
force-pushed
the
linter
branch
3 times, most recently
from
2199aaa to
f35b97e
Compare
Collaborator
Author
|
I covered most of the possible combinations of types, but I couldn't copy the same types as the base itk filters because there is a lot of conditional wrapping, I prefered keep it simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #69
I am not sure if wrapping all those types is really necessary.