Skip to content

Conversation

@dnwillia23
Copy link
Collaborator

Description

Changed regex getting the list of FASTQs in the working directory


Dockerfile Structure and Organization:

  • Does the Dockerfile build?
  • Is tool organized according to Repository Structure?
  • Specific base image with a version tag, e.g., FROM ubuntu:24.04 instead of FROM ubuntu.
  • Add comments to describe each Dockerfile step.

Metadata

Include the following LABELs:

  • LABEL maintainer="Your Name <your.email@rti.org>"
  • LABEL base-image="ubuntu:24.04"
  • LABEL description="Short description of the purpose of this image"
  • LABEL software-website="https://example.com"
  • LABEL software-version="1.0.0"
  • LABEL license="https://www.example.com/legal/end-user-software-license-agreement"

File and Resource Management:

  • Store scripts, files, and software tools ONLY in /opt.
  • Removing tar files after extraction and delete temporary files and caches generated during the build process.
  • Ensure sensitive data (e.g., API keys, passwords) is not hardcoded in the Dockerfile.

Container Behavior

  • Specify a meaningful CMD to define how the container should run by default (help message is a good default).

@dnwillia23 dnwillia23 requested a review from jaamarks December 15, 2025 13:52
@jaamarks jaamarks merged commit f60e5f3 into RTIInternational:master Dec 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants