Skip to content

Conversation

@carynwillis
Copy link
Contributor

Description

After the last update, I realized read.xlsx removed spaces in column names. This PR keeps the spaces.

Dockerfile Structure and Organization:

  • Does the Dockerfile build?
  • Is tool organized according to Repository Structure?
  • Specific base image with a version tag, e.g., FROM ubuntu:24.04 instead of FROM ubuntu.
  • Add comments to describe each Dockerfile step.

Metadata

Include the following LABELs:

  • LABEL maintainer="Your Name <your.email@rti.org>"
  • LABEL base-image="ubuntu:24.04"
  • LABEL description="Short description of the purpose of this image"
  • LABEL software-website="https://example.com"
  • LABEL software-version="1.0.0"
  • LABEL license="https://www.example.com/legal/end-user-software-license-agreement"

File and Resource Management:

  • Store scripts, files, and software tools ONLY in /opt.
  • Removing tar files after extraction and delete temporary files and caches generated during the build process.
  • Ensure sensitive data (e.g., API keys, passwords) is not hardcoded in the Dockerfile.

Container Behavior

  • Specify a meaningful CMD to define how the container should run by default (help message is a good default).

Copy link
Collaborator

@dnwillia23 dnwillia23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and code documentation. Approved

@dnwillia23 dnwillia23 merged commit 57f45cf into RTIInternational:master Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants