Reactive elements alpha transform #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpiler will exit with an error at compile time.
Collaborator
|
We are having conflicts here with your previous PR, do you have time to look into this? |
Author
|
Travelling until tomorrow. Will resolve conflicts when I get back, cheers! |
Author
|
Alright, I tried to resolve the conflicts. Both on this PR and in this commit. How should we move forward? |
Collaborator
|
Thanks! I will test and merge manually over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter associated with the alpha-transform (numerical scheme). Now users can optionally pass in a parameters to each reactive element to choose any alpha transform, e.g., alpha=1.0 is bilinear transform (default value), alpha=0 is backwards Euler.