Skip to content

Updates for Simplex implementation#69

Merged
bvscd merged 1 commit intorelease/node/v0.5.0from
simplex_upgrade
Apr 8, 2026
Merged

Updates for Simplex implementation#69
bvscd merged 1 commit intorelease/node/v0.5.0from
simplex_upgrade

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented Apr 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 05:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements major updates to the Simplex consensus protocol implementation, transitioning from a get_committed_candidate callback-based approach to a finalized-driven delivery model via on_block_finalized(). The changes affect multiple layers of the validator infrastructure including listener interfaces, session management, and network context handling.

Changes:

  • Replace get_committed_candidate with on_block_finalized callback for finalized block delivery
  • Implement OnAppliedTop action type for spreading MC-applied-top information to simplex sessions
  • Refactor validator list network readiness tracking from network_ready flag to context-based checking
  • Remove RestartRecommitStrategy enum and simplify startup recovery
  • Update ValidatorListOutcome to remove network_ready field and check context separately
  • Add extensive simplex state refactoring and timing fixes
  • Implement standstill recovery and egress budget management

Reviewed changes

Copilot reviewed 41 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/node/src/validator/validator_session_listener.rs Replaces OnGetCommittedCandidate with OnAppliedTop and OnBlockFinalized enum variants and implements corresponding handler
src/node/src/validator/validator_manager.rs Refactors validator list network readiness tracking; updates notify_simplex_sessions_applied_tops function; implements applied-top-based session management
src/node/src/validator/validator_group.rs Adds on_block_finalized method for out-of-order finalized block delivery; adds test for sync_last_accepted_mc_seqno_from_applied_top
src/node/src/validator/consensus.rs Updates notify_mc_finalized to use BlockIdExt instead of seqno; removes CommittedBlockProof imports
src/node/src/network/node_network.rs Adds resolve_validator_adnl_key method; updates overlay peer addition logic; adds has_validator_list_context method
src/node/src/engine_traits.rs Removes network_ready field from ValidatorListOutcome; adds has_validator_list_context method to PrivateOverlayOperations
src/node/simplex/src/lib.rs Removes RestartRecommitStrategy enum; updates on_block_finalized documentation throughout
Simplex tests Updates test listeners to implement on_block_finalized instead of old callback paths; refactors seqno tracking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@LenyKholodov LenyKholodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bvscd bvscd merged commit 161ac60 into release/node/v0.5.0 Apr 8, 2026
9 checks passed
@bvscd bvscd deleted the simplex_upgrade branch April 8, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants