Open
Conversation
Begins implementing the BFPRG conversion rules, starting with character add. Updates the source abilities on both to the conversion scripts, through GSP.
Finishes implementing the BFPRG conversion rules, for both add and import. Adds new sample character for BFRPG, and also updates the OpenD6 character to include custom capabilities. Note that in this update, issue discovered with BCIRPG Percentile backend import of custom capabilities and csv output. This has been created as additional item to address, and is in progress.
Working through BCI Percentile, OpenD6, and BFRPG character add and import, with capabilities addition cleanup. Resolves: *BCI Percentile output mods for caps system for csv fix *Test character cleanup Still needed: remove blank field addition on imports with set capabilities.
Finalizes corrections, updates BFRPG sample character. PASSED: OpenD6: import Falstaff; works in-game OpenD6: import Falstaff and add capability (Drinking); works in-game and CSV looks good OpenD6: add character (PJ) w capability; works in-game and CSV looks good BCIPerc: import Bilbo; works in-game BCIPerc: import Bilbo and add capability (Cooking); works in-game and CSV looks good BCIPerc: add character (DC) w capability; works in-game and CSV looks good BFRPG: import Strider; works in-game BFRPG: import Strider; works in-game BFRPG: add character (LSW) w capability; works in-gamd and CSV looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing and modifications across the three game systems for import and add. Completes initial GSP character creation phase for MVP.