Add --no-cache flag to build_dockers and build_base_dockers#343
Open
Add --no-cache flag to build_dockers and build_base_dockers#343
Conversation
Allow developers to force a clean Docker build without relying on the local layer cache, which may go stale on long-lived machines. When --no-cache is passed to build_base_dockers, the base image is rebuilt from scratch with --no-cache and --pull. When passed to build_dockers, the base image is unconditionally rebuilt and the jax image build receives --cache-from pointing at the freshly-built base so that Docker can still reuse its layers. Also fix a pre-existing bug where add_llvm flags would clobber extra_args instead of extending them, and reformat with black.
gulsumgudukbay
requested changes
Mar 6, 2026
Add ArgumentDefaultsHelpFormatter to the main parser and all subparsers so that --help displays default values for every option.
gulsumgudukbay
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow developers to force a clean Docker build without relying on the local layer cache, which may go stale on long-lived machines. When --no-cache is passed to build_base_dockers, the base image is rebuilt from scratch with --no-cache and --pull. When passed to build_dockers, the base image is unconditionally rebuilt and the jax image build receives --cache-from pointing at the freshly-built base so that Docker can still reuse its layers.
Also fix a pre-existing bug where add_llvm flags would clobber extra_args instead of extending them, and reformat with black.
Technical Details
When passing --no-cache to ci_build, the build passes --no-cache and --pull to the docker command building the base container. This will ensure that both the container and the base image (ubuntu 24.04) get updated.
Test Plan
Verify that containers get built without using the cache when --no-cache is passed.
Test Result
Passed.
Submission Checklist