Skip to content

Added extra command line option to turn off rccl for causal tests #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pranswarup wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
Draft

Added extra command line option to turn off rccl for causal tests #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion source/bin/omnitrace-causal/impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,11 @@ parse_args(int argc, char** argv, std::vector<char*>& _env,
.action([&](parser_t& p) {
update_env(_env, "OMNITRACE_CAUSAL_DURATION", p.get<double>("duration"));
});

parser
.add_argument({ "--nrccl" },
"Don't set Use_RCCLP environment variable to true.")
.max_count(1);

int64_t _niterations = 1;
auto _virtual_speedups = std::vector<std::string>{};
Expand Down Expand Up @@ -828,7 +833,17 @@ parse_args(int argc, char** argv, std::vector<char*>& _env,
#endif

#if defined(OMNITRACE_USE_RCCL) && OMNITRACE_USE_RCCL > 0
add_default_env(_env, "OMNITRACE_USE_RCCLP", true);
bool add_to_env = true;
for(int i = 0; i < argc; ++i)
{
if(std::string_view{ argv[i] } == "--nrccl")
{
add_to_env = false;
}
}
if (add_to_env){
add_default_env(_env, "OMNITRACE_USE_RCCLP", true);
}
#endif
}

Expand Down
2 changes: 1 addition & 1 deletion tests/omnitrace-testing.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ function(OMNITRACE_ADD_CAUSAL_TEST)

if(TARGET ${TEST_TARGET})
set(COMMAND_PREFIX $<TARGET_FILE:omnitrace-causal> --reset -m ${TEST_CAUSAL_MODE}
${TEST_CAUSAL_ARGS} --)
${TEST_CAUSAL_ARGS} --nrccl --)

if(NOT TEST_SKIP_BASELINE)
add_test(
Expand Down
Loading