Fix HIP memory leaks in RNN kernels#727
Draft
magaonka-amd wants to merge 1 commit intoROCm:rocm-jaxlib-v0.8.0from
Draft
Fix HIP memory leaks in RNN kernels#727magaonka-amd wants to merge 1 commit intoROCm:rocm-jaxlib-v0.8.0from
magaonka-amd wants to merge 1 commit intoROCm:rocm-jaxlib-v0.8.0from
Conversation
Free dropout_states_dev GPU memory allocated via gpuMalloc in the HIP paths of DoRnnComputeWorkspaceReserveSpaceSizes, DnnRNNForward_, and DnnRNNBackward_. Also destroy the leaked miopenTensorDescriptor in the forward and backward functions.
magaonka-amd
force-pushed
the
fix/rnn-hip-memleak-v0.8.0
branch
from
171f15a to
559571d
Compare
Arech8
reviewed
Mar 5, 2026
| #define GPU_STREAM_NON_BLOCKING hipStreamNonBlocking | ||
|
|
||
| #define gpuMalloc hipMalloc | ||
| #define gpuFree hipFree |
There was a problem hiding this comment.
I can't believe it's not there yet...
Note, a corresponding entry is needed for CUDA too, and this needs to be upstreamed too
There was a problem hiding this comment.
Ok, saw the upstream link in the descipriton, awesome. Then just an update for CUDA is needed.
Author
There was a problem hiding this comment.
yep very funny to me aswell. looks like we have unlimited memory no need to free it. just keep using it :).
okay I'll update upstream aswell. thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free dropout_states_dev GPU memory allocated via gpuMalloc in the HIP paths of DoRnnComputeWorkspaceReserveSpaceSizes, DnnRNNForward_, and DnnRNNBackward_.
Upstream PR: jax-ml#35638