Skip to content

Skip test_pmap on ROCm due to IndivisibleError with new pmap SPMD tiling #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AratiGanesh wants to merge 1 commit into
base: rocm-jaxlib-v0.9.0
Choose a base branch
from
Open

Skip test_pmap on ROCm due to IndivisibleError with new pmap SPMD tiling #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/ann_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@ def test_autodiff(self, shape, dtype, k, is_max_k):
)
def test_pmap(self, qy_shape, db_shape, dtype, k, recall):
num_devices = jax.device_count()
# TODO(araganes): Re-enable once upstream HloShardingV3 lands (JAX 0.9.2+).
# New pmap's SPMD tiling can't convert back to 1D pmap mesh on ROCm.
if jtu.is_device_rocm():
self.skipTest("IndivisibleError - SPMD tiling incompatible with 1D pmap mesh on ROCm")
rng = jtu.rand_default(self.rng())
qy = rng(qy_shape, dtype)
db = rng(db_shape, dtype)
Expand Down