Skip test_tridiagonal_solve_grad test 0.8.0#701
Open
AratiGanesh wants to merge 1 commit intorocm-jaxlib-v0.8.0from
Open
Skip test_tridiagonal_solve_grad test 0.8.0#701AratiGanesh wants to merge 1 commit intorocm-jaxlib-v0.8.0from
AratiGanesh wants to merge 1 commit intorocm-jaxlib-v0.8.0from
Conversation
AratiGanesh
changed the title
AratiGanesh
force-pushed
the
skip-tridiagonal-solve-grad-v0.8.0
branch
from
50088a5 to
fe8d3e9
Compare
AratiGanesh
added
cherry-pick-candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_tridiagonal_solve_gradtest fails on ROCm devices due to numerical precision issues in the underlying rocSparse library.Technical Details
Test Result
Upstream PR - jax-ml#34959
Submission Checklist
Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.