Skip testEighTinyNorm test 0.9.0#699
Open
AratiGanesh wants to merge 3 commits intorocm-jaxlib-v0.9.0from
Open
Conversation
AratiGanesh
added
open-upstream
AratiGanesh
force-pushed
the
skip-eigh-tiny-norm-v0.9.0
branch
from
532dc20 to
f284f35
Compare
AratiGanesh
force-pushed
the
skip-eigh-tiny-norm-v0.9.0
branch
from
f284f35 to
6c5850d
Compare
|
@AratiGanesh there's a conflict in this PR |
Author
Resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The testEighTinyNorm test fails on ROCm devices due to numerical precision issues in the underlying hipSolver https://ontrack-internal.amd.com/browse/SWDEV-578349
Technical Details
Added @jtu.skip_on_devices("rocm") decorator to skip testEighTinyNorm in `tests/linalg_test.py
Test Result
Submission Checklist
Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.