remove skipTest associated to hipsparse transpose#661
remove skipTest associated to hipsparse transpose#661kliegeois wants to merge 1 commit intoROCm:rocm-jaxlib-v0.8.0from
Conversation
|
I tested the changes from PR ROCm/rocm-libraries#4111 by building hipsparse/rocsparse from the develop branch inside the container, but encountered a segmentation fault. Environment - jaxlib 0.8.0+rocm7.2.0, Python 3.11.13, GPU gfx1201 Build steps cd /rocm-libraries/projects/rocsparse cd /rocm-libraries/projects/hipsparse Test with hipsparse 4.3.0 Result - Segmentation fault in csr_fromdense_gpu_lowering Could you please share the environment you used for testing? It appears to be an ABI compatibility issue between the 4.3.0 build and tjaxlib version. |
|
The tests pass as expected root@8546edac53b3:~# /root/kim/run_tests.sh > /root/test_results.log 2>&1 tests/sparse_test.py . [100%] ============================== 1 passed in 10.49s ============================== tests/sparse_test.py . [100%] ============================== 1 passed in 8.23s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 8.29s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 8.23s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.28s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.23s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.30s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.23s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.51s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.75s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.76s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.73s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.71s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 6.72s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 7.06s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 7.14s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 7.28s =============================== tests/sparse_test.py . [100%] ============================== 1 passed in 7.12s =============================== |
Once ROCm/rocm-libraries#4111 is merged and used by ROCm/jax CI, these skipTest can be removed.