Skip to content

Refactor AISUseGTest.cmake to eliminate FetchContent_Declare duplication #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Refactor AISUseGTest.cmake to eliminate FetchContent_Declare duplication #211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5747f
Initial plan
Copilot Mar 5, 2026
67e7d9b
Refactor FetchContent_Declare to avoid duplication using a variable
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions cmake/AISUseGTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,22 @@

include(FetchContent)

# This line is used (or not) in FetchContent_Declare to determine
# if we check for a system GoogleTest install first. When building
# with the sanitizers, we HAVE to build GoogleTest from source.
#
# lint_cmake: -readability/wonkycase
# When building with the sanitizers, we HAVE to build GoogleTest from source,
# so we skip the system package check. Otherwise, check for a system install first.
if(AIS_USE_SANITIZERS OR AIS_USE_INTEGER_SANITIZER OR AIS_USE_THREAD_SANITIZER)
FetchContent_Declare(
googletest
URL https://github.com/google/googletest/releases/download/v1.17.0/googletest-1.17.0.tar.gz
DOWNLOAD_EXTRACT_TIMESTAMP true
SYSTEM
)
set(_gtest_find_package_args "")
else()
FetchContent_Declare(
googletest
URL https://github.com/google/googletest/releases/download/v1.17.0/googletest-1.17.0.tar.gz
DOWNLOAD_EXTRACT_TIMESTAMP true
FIND_PACKAGE_ARGS NAMES GTest # <-- Different
SYSTEM
)
set(_gtest_find_package_args FIND_PACKAGE_ARGS NAMES GTest)
endif()

# lint_cmake: -readability/wonkycase
FetchContent_Declare(
googletest
URL https://github.com/google/googletest/releases/download/v1.17.0/googletest-1.17.0.tar.gz
DOWNLOAD_EXTRACT_TIMESTAMP true
${_gtest_find_package_args}
SYSTEM
)
# lint_cmake: +readability/wonkycase

set(INSTALL_GTEST OFF CACHE BOOL "Don't install GoogleTest")
Expand Down