[Windows] Add hasattr checks for distributed to improve compatibility#171
Open
0xDELUXA wants to merge 1 commit intoROCm:tridaofrom
Open
[Windows] Add hasattr checks for distributed to improve compatibility#1710xDELUXA wants to merge 1 commit intoROCm:tridaofrom
hasattr checks for distributed to improve compatibility#1710xDELUXA wants to merge 1 commit intoROCm:tridaofrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Without these checks, ROCm on Windows raises an
AttributeErrorwhen importing certain distributed functions.For example, when adding a custom node to ComfyUI:
This PR adds
hasattrchecks to prevent this error. It is not expected to cause any issues on Linux.Technical Details
Improves ROCm compatibility with FlashAttention-2 on Windows.
Specifications:
GPU: AMD Radeon RX 9060 XT
Python: 3.12.10
PyTorch: 2.11.0a0+rocm7.11.0a20260121 (TheRock)
Triton: 3.6.0a0.post25 (triton-windows)
OS: Windows 11
Test Plan
Functional testing on AMD Radeon RX 9060 XT (gfx1200).
Test Result
All existing Triton Flash Attention tests pass on gfx1200.
The
AttributeErrorhas been resolved.