[Feature] Bump hipCollections version #16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| build/ | ||
| graphbolt/build/ | ||
| dgl_sparse/build/ | ||
| tensoradapter/pytorch/build/ | ||
| python/build/ | ||
| python/dist/ | ||
| python/*.egg-info/ | ||
| python/libdgl.so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,66 +1,41 @@ | ||||||
| #!/usr/bin/env bash | ||||||
|
|
||||||
| ROCM_ROOT=/opt/rocm | ||||||
|
|
||||||
| export CC=${ROCM_ROOT}/llvm/bin/clang | ||||||
| export CXX=${ROCM_ROOT}/llvm/bin/clang++ | ||||||
|
|
||||||
| set -x | ||||||
| INSTALL_PREFIX=${ROCM_ROOT} | ||||||
| FILE_SOURCE_DIR=$(dirname $(realpath $0)) | ||||||
| DEPS_DIR=$(pwd) | ||||||
| export CMAKE_PREFIX_PATH="/opt/rocm/hip/lib/cmake;/opt/rocm/lib/cmake" | ||||||
|
|
||||||
| git clone https://github.com/ROCm/hipCollections.git -b release/rocmds-25.10 | ||||||
| export RAPIDS_CMAKE_SCRIPT_BRANCH=release/rocmds-25.10 | ||||||
| cd hipCollections | ||||||
| cmake -B build \ | ||||||
| -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} -DINSTALL_CUCO=ON -DBUILD_TESTS=OFF -DBUILD_BENCHMARKS=OFF -DBUILD_EXAMPLES=OFF | ||||||
| cmake --build build --target install | ||||||
| cd ${DEPS_DIR} | ||||||
|
|
||||||
| # TODO this is an unacceptable way to do this, | ||||||
| # see https://github.com/ROCm/libhipcxx/issues/10 for more details | ||||||
| # This was implicitly not allowed in previous releases we were using, | ||||||
| # but with v2.7.0 they are explicitly not allowed. | ||||||
|
|
||||||
| # We only use semaphores for a counter of IO operations in graphbolt, | ||||||
| # that only runs on the host (not on the device) so we should be "safe" | ||||||
| # to use this for now. | ||||||
| sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/cuda/semaphore | ||||||
| sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/hip/semaphore | ||||||
| sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/cuda/std/semaphore | ||||||
| sed -i '/#error semaphore is not supported on AMD hardware and should not be included/d' ${INSTALL_PREFIX}/include/rapids/libhipcxx/hip/std/semaphore | ||||||
|
|
||||||
| # TODO remove this once the patches are merged | ||||||
|
Collaborator
There was a problem hiding this comment. I recommend tagging all TODOs with a corresponding GitHub issue, e.g.
Collaborator
Author
There was a problem hiding this comment. Yea this is a miss by myself when I added this todo a couple of weeks ago. It's tracked with an internal ticket and I'm trying to find the public reference. I think it's already been merged into the rocm-libraries, but those changes weren't included in several important releases of rocm (e.g. 7.0.0 and 7.1.0). I'll track down the links and add them here
Collaborator
Author
There was a problem hiding this comment. So it was merged into the develop branch on rocm-libraries here: ROCm/rocm-libraries#1883. Not sure when it will get included in the rocm release though. I've added a link to this PR and more comments here to better document this.
Collaborator
There was a problem hiding this comment. Yeah I was suggesting something like making an issue in this repo to fix this and linking this TODO to that issue. Same with the TODO above. So it would be
Suggested change
and then issue dmlc#1234 can have all the necessary detail. I think it would also be more self-explanatory if rather than copying all the lose header files in this directory, this applied this upstream commit as a patch, but anyways, this is all kind of unrelated to your change here. |
||||||
| # the patches for this were merged in https://github.com/ROCm/rocm-libraries/pull/1883 | ||||||
| # but may take more time to be released. | ||||||
|
|
||||||
| # Right now we need to patch the rocPRIM headers to fix the build because these | ||||||
| # config headers are missing gfx942 (I've added them manually) | ||||||
| cp ${FILE_SOURCE_DIR}/*.hpp ${INSTALL_PREFIX}/include/rocprim/device/detail/config/. | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just a reformatting? Maybe revert, as it seems unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just reformatting, but it seems like it was incorrect before. When I made changes to the file, it then tripped the CI checks here so even though it's separate from the important changes here, I think we should keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think such linters should really only be looking at modified lines, but I see it comes from upstream, so no need to fight it.