fix: allow non-amd.json filenames for cdi spec #81
+17
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have options in the command to accept the output file path for
amd-ctk cdi generatecommand, but we still refuse to create file not named amd.json. Similar foramd-ctk cdi validate. Ideally we should just care about defaults and honor the users if they want to get file with a different name.Technical Details
Removed the checks in the command to validate the file name.
Test Plan
Tested on a machine with gpus to generate a file with the name
abc.json.Test Result
Was successfully able to get the cdi file.
Submission Checklist