fix: allow non root user generate and validate the cdi spec #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv-tyagi
force-pushed
the
allow-non-root-cdi
branch
from
f813465 to
5381b2f
Compare
shiv-tyagi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows a non root user to generate a cdi spec. If the user does not have rights to write to the output location, they will get a permission denied error, otherwise the command should work fine and the user should should get the spec.
Technical Details
We just remove the are you root check for the command.
Test Plan
Tested on a machine with GPUs to see if a non root user is successfully able to create a cdi spec which lists the gpus on the machine.
Test Result
The user was successfully able to generate the file
Submission Checklist