Integrate Broadcom Devices in amd-smi framework #71
Conversation
Signed-off-by: Joseph Narlo <joseph.narlo@amd.com>
1. As part of this we have added Broadcom's NIC and SWITCH devices in the amd-smi framework. 2. The affected command is 'amd-smi list' 3. Filter the NIC and SWITCH devices based on the Broadcom's vendor ids 4. Since these changes are depending on sysfs entries which is created by broadcom drivers, if no brcm driver present in the system then necessary elements will not created as part of the list command.
…MD-ROCm-Internal/amdsmi into SWDEV-504389/Synch_Comment_In_Linux_BM
Comments added
NIC/Switch LIST
List Nic/Switch
mcharles-brcm
requested review from
bill-shuzhou-liu,
charis-poag-amd,
dmitrii-galantsev,
marifamd and
oliveiradan
as code owners
As part of this feature, 1. Added monitor attributes for BRCM devices - NIC and SWITCH 2. The affected amd-smi command is 'amd-smi monitor' 3. The list of monitor attributes are read from the corresponding BRCM device's sysfs path
BRCM Monitor
BRCM Monitor
…imestamp from firmware. (ROCm#61) * SWDEV-511296 - update violation_status->violation_timestamp to read values from firmware. Signed-off-by: Greg Scaffidi <salvatore.scaffidi@amd.com> * SWDEV-511296 - update violation_status->violation_timestamp to read values from firmware. Signed-off-by: Greg Scaffidi <salvatore.scaffidi@amd.com> * SWDEV-511296 - update violation_status->violation_timestamp to read values from firmware. Signed-off-by: Greg Scaffidi <salvatore.scaffidi@amd.com> --------- Signed-off-by: Greg Scaffidi <salvatore.scaffidi@amd.com>
Fix ordering of RHEL 8 build process Signed-off-by: Williams, Justin <Justin.Williams@amd.com>
dmitrii-galantsev
force-pushed
the
amd-staging
branch
from
9872083 to
09379f8
Compare
|
ohhh that's cool, I'll ask some teammates to see if they want to take on broadcom things. continue internally |
Affected Commands: 1. amd-smi topology -nic Display nic and gpu connectivity 2. amd-smi topology -show_numa Display nic,gpu's numa and cpu affinity
1. Remove duplicate declaration 2. Resolve Alignment issue
|
Hi All, We initiated this pull request on January 26th and have delivered most of the changes over the past six months. The recent suggestions are specific to reorganize / modernize the delivered code, it appears to be a rework of our previous deliveries. It would have been more efficient if we had received this feedback earlier, as we could have incorporated it into our regular delivery process. Our goal is to upstream some of the initial deliveries to the mainline and gather feedback from BRCM customers on the integrated feature. In parallel, we can certainly implement your suggested changes, though this will require additional effort and time. Here are some examples of our initial deliveries that cannot be moved out of the core (except by adding the preprocessor):
Please let me know if you have any questions. |
Integrate dump command for brcm switch and nic components.
Incorporated review comments
Defect Fixes: 1. skipping the bad data checking 2. remove additional new line on monitor attributes display
…into amd-staging
…into amd-staging
Make brcm-smi as a separate module and on demand basis include it in amd-smi framework. ENABLE_BRCM_SMI ON / OFF
Test ENABLE_BRCM_SMI with OFF option
Guarded with ENABLE_BRCM_SMI flag
…into amd-staging
|
Hi bill-shuzhou-liu Below is the sample output when ENABLE_BRCM_SMI is OFF. amd-smi monitorGPU XCP POWER GPU_T MEM_T GFX_CLK GFX% MEM% ENC% DEC% VRAM_USAGE amd-smi monitor -nicERROR | 2025-09-30 18:10:07.923 | amdsmi_commands.py:7588 | NIC monitoring requires BRCM SMI support. Please rebuild with -DENABLE_BRCM_SMI=ON Please let us know any query on this implementation. |
|
Hi bill-shuzhou-liu and oliveiradan, |
7 participants
As part of this feature,
Updated (1/27)
i) NIC_TEMP_CURRENT
ii) NIC_TEMP_CRIT_ALARM
iii) NIC_TEMP_EMERGENCY_ALARM
iv) NIC_TEMP_SHUTDOWN_ALARM
v) NIC_TEMP_MAX_ALARM
i) CURRENT_LINK_SPEED
ii) MAX_LINK_SPEED
iii) CURRENT_LINK_WIDTH
iv) MAX_LINK_WIDTH