fix(python): fix comparison to True/False #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-kwsm
requested review from
bill-shuzhou-liu,
charis-poag-amd,
dmitrii-galantsev,
marifamd and
oliveiradan
as code owners
e-kwsm
force-pushed
the
E712
branch
2 times, most recently
from
41fef74 to
1f4bdf9
Compare
Collaborator
|
Can you remove the rocm-smi.py changes? rocm-smi.py is a leftover from the rocm-smi project, and not intended to be changed independtly in this project. If you have any rocm-smi changes you can make them in https://github.com/ROCm/rocm_smi_lib. Otherwise the changes look good |
dmitrii-galantsev
force-pushed
the
E712
branch
from
6f9c2fc to
6135a2d
Compare
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or > is not, never the equality operators. Change-Id: I710d64c380eaf420f0ad29e65623ee677b094051 Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
dmitrii-galantsev
force-pushed
the
E712
branch
from
6135a2d to
866e2dd
Compare
dmitrii-galantsev
pushed a commit
that referenced
this pull request
Jan 13, 2025
Updated AMDSMI Dockerfile Signed-off-by: Justin Williams <Justin.Williams@amd.com>
dmitrii-galantsev
force-pushed
the
amd-staging
branch
from
234704f to
bd82e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations):