Fix compilation with libdrm-2.4.130 #165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error: redefinition of 'struct drm_color_ctm_3x4'. drm_color_ctm_3x4 structure is now defined in torvalds/linux@e5719e7#diff-4c51fb416ec7cc69566cd7b795ee57eb070aa1006ad65d6962081f039ffb2718 As this structure is unused and not a part of amdsmi public interface, it is safe to remove it.
AngryLoki
requested review from
charis-poag-amd,
dmitrii-galantsev,
marifamd and
oliveiradan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Originally reported in https://bugs.gentoo.org/967246. amdsmi fails to compile with the latest libdrm-2.4.130 with error: redefinition of 'struct drm_color_ctm_3x4'.
drm_color_ctm_3x4 structure is now defined in torvalds/linux@e5719e7#diff-4c51fb416ec7cc69566cd7b795ee57eb070aa1006ad65d6962081f039ffb2718
Technical Details
As this structure is unused and not a part of amdsmi public interface, it is safe to remove it.
Test Plan
N/A, it's a dead code removal, which fixes compilation error.
Test Result
It compiles with libdrm-2.4.130
Submission Checklist