Added --decode argument to amd-smi so we can parse cper files directly #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com> remove debug print updated from PR comments Add --decode option to --afid help show AFIDS when --decode option is given wip use file name
Author
|
Please clear this with Lenka on the feature design page. |
rocm-devops
requested review from
charis-poag-amd,
dmitrii-galantsev and
oliveiradan
as code owners
Author
|
Is that your custom tool? It looks like you merged cper and afid arguments in one command. Per our agreement, cper command should stay the same, and for afid we are just adding --decode option to the existing command: sudo amd-smi ras --afid --cper-file=fatal-1.cper --decode if we want to decode cper, if not behavior stays the same as previously (amd-smi ras --afid --cper-file=fatal-1.cper) |
Author
|
!verify |
Author
|
Error importing due to merge conflicts – please reopen the PR on ROCm/rocm-systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==================================================================
Adjusted output to match design requirements:
Sample output: