Skip to content

[cmake] Fix dependencies. #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stellaraccident wants to merge 4 commits into
base: amd-staging
Choose a base branch
from
Open

[cmake] Fix dependencies. #128

stellaraccident wants to merge 4 commits into from

Conversation

@stellaraccident
Copy link
Contributor

@stellaraccident stellaraccident commented Sep 24, 2025 •
edited
Loading

  • Use CMAKE_DL_LIBS instead of hard-coded dl.
  • Use Threads::Threads instead of pthread.
  • Find libdrm via pkgconfig (consistent to how other ROCm projects do it as documented here: https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md#libdrm)
  • Discovers the SONAME of libdrm_amdgpu used to build (and that matches headers) and puts this in a new config header so that it can be used by dlopen instead of the generic "libdrm_amdgpu.so" (which could be anything and is only guaranteed available in some cases with dev packages installed).

@stellaraccident
[cmake] Fix dependencies.
9347cc5 
* Use CMAKE_DL_LIBS instead of hard-coded `dl`.
* Use Threads::Threads instead of `pthread`.
* Drop `rt` dep.
* Find libdrm via pkgconfig (consistent to how other ROCm projects do it as documented here: https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md#libdrm)
stellaraccident and others added 3 commits September 24, 2025 15:40
@stellaraccident
Add rt dep back
59f055c
@stellaraccident
Fix delay loading of drm by soname.
64e7483
@marifamd
Change libdrm.so.2 references to dynamic libdrm naming
725c20f 
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ie02c91a3a210ab7612fec670b2aad66d476d2cf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marifamd marifamd Awaiting requested review from marifamd marifamd is a code owner

@dmitrii-galantsev dmitrii-galantsev Awaiting requested review from dmitrii-galantsev dmitrii-galantsev is a code owner

@charis-poag-amd charis-poag-amd Awaiting requested review from charis-poag-amd charis-poag-amd is a code owner

@oliveiradan oliveiradan Awaiting requested review from oliveiradan oliveiradan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stellaraccident @marifamd