Reapply "Move non-sysdep third-party projects after base and compiler"#3440
Draft
Reapply "Move non-sysdep third-party projects after base and compiler"#3440
Conversation
ScottTodd
commented
Feb 17, 2026
Comment on lines
409
to
413
| [artifacts.spdlog] | ||
| artifact_group = "third-party-libs" | ||
| type = "target-neutral" | ||
| artifact_deps = [] | ||
| artifact_deps = ["amd-llvm"] | ||
| feature_group = "CORE" |
Member
Author
There was a problem hiding this comment.
Run multi-arch CI on this branch: https://github.com/ROCm/TheRock/actions/runs/22081286467
- look for spdlog artifact
- check build logs for "Foundation" stage (should NOT include spdlog)
- check build logs for "Compiler Runtime" stage (should include spdlog)
Needs more work, now failed later: https://github.com/ROCm/TheRock/actions/runs/22081286467/job/63808205092#step:13:229
-- Including subproject hipBLAS-common (from /__w/TheRock/TheRock/rocm-libraries/projects/hipblas-common)
-- Including subproject rocRoller (from /__w/TheRock/TheRock/rocm-libraries/shared/rocroller)
CMake Error at cmake/therock_subproject.cmake:1169 (get_target_property):
get_target_property() called with non-existent target "therock-spdlog".
Call Stack (most recent call first):
cmake/therock_subproject.cmake:1269 (_therock_assert_is_cmake_subproject)
cmake/therock_subproject.cmake:389 (_therock_cmake_subproject_collect_build_deps)
math-libs/BLAS/CMakeLists.txt:52 (therock_cmake_subproject_declare)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reverts #3439 to reapply #2045.
Technical Details
The original PR was missing changes in
BUILD_TOPOLOGY.tomland did not safely guardadd_subdirectory(spdlog)in the CMake source. If we switch more third-party subprojects to use the amd-llvm toolchain they will need similar changes.We could re-evaluate the build stages as "Foundation" gets smaller and "Compiler Runtime" gets larger (could merge them or split out a new stage for third party deps that use the compiler 🤔).
Test Plan
Run multi-arch CI on this branch: https://github.com/ROCm/TheRock/actions/runs/22081286467
Test Result
Pending
Submission Checklist