Skip to content

Reapply "Move non-sysdep third-party projects after base and compiler"#3440

Draft
ScottTodd wants to merge 2 commits intomainfrom
users/scotttodd/roll-forward-2045
Draft

Reapply "Move non-sysdep third-party projects after base and compiler"#3440
ScottTodd wants to merge 2 commits intomainfrom
users/scotttodd/roll-forward-2045

Conversation

@ScottTodd
Copy link
Member

Motivation

This reverts #3439 to reapply #2045.

Technical Details

The original PR was missing changes in BUILD_TOPOLOGY.toml and did not safely guard add_subdirectory(spdlog) in the CMake source. If we switch more third-party subprojects to use the amd-llvm toolchain they will need similar changes.

We could re-evaluate the build stages as "Foundation" gets smaller and "Compiler Runtime" gets larger (could merge them or split out a new stage for third party deps that use the compiler 🤔).

Test Plan

Run multi-arch CI on this branch: https://github.com/ROCm/TheRock/actions/runs/22081286467

  • look for spdlog artifact
  • check build logs for "Foundation" stage (should NOT include spdlog)
  • check build logs for "Compiler Runtime" stage (should include spdlog)

Test Result

Pending

Submission Checklist

Comment on lines 409 to 413
[artifacts.spdlog]
artifact_group = "third-party-libs"
type = "target-neutral"
artifact_deps = []
artifact_deps = ["amd-llvm"]
feature_group = "CORE"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run multi-arch CI on this branch: https://github.com/ROCm/TheRock/actions/runs/22081286467

  • look for spdlog artifact
  • check build logs for "Foundation" stage (should NOT include spdlog)
  • check build logs for "Compiler Runtime" stage (should include spdlog)

Needs more work, now failed later: https://github.com/ROCm/TheRock/actions/runs/22081286467/job/63808205092#step:13:229

-- Including subproject hipBLAS-common (from /__w/TheRock/TheRock/rocm-libraries/projects/hipblas-common)
-- Including subproject rocRoller (from /__w/TheRock/TheRock/rocm-libraries/shared/rocroller)
CMake Error at cmake/therock_subproject.cmake:1169 (get_target_property):
  get_target_property() called with non-existent target "therock-spdlog".
Call Stack (most recent call first):
  cmake/therock_subproject.cmake:1269 (_therock_assert_is_cmake_subproject)
  cmake/therock_subproject.cmake:389 (_therock_cmake_subproject_collect_build_deps)
  math-libs/BLAS/CMakeLists.txt:52 (therock_cmake_subproject_declare)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant