Skip to content

Add Apex to the Pytorch Manifest file#3431

Open
erman-gurses wants to merge 1 commit intomainfrom
users/erman-gurses/add-apex-to-pytorch-manifest
Open

Add Apex to the Pytorch Manifest file#3431
erman-gurses wants to merge 1 commit intomainfrom
users/erman-gurses/add-apex-to-pytorch-manifest

Conversation

@erman-gurses
Copy link
Contributor

@erman-gurses erman-gurses commented Feb 16, 2026

Motivation

Add Apex to the Pytorch Manifest file
Follow up PR for #2547

Test Plan

Test on CI

Test Result

The test runs: https://github.com/ROCm/TheRock/actions/runs/22070943413

Example Manifest from the test:

{
  "pytorch": {
    "commit": "f466ea7ac710374ce7066d9ead92e57dc42dc76f",
    "repo": "https://github.com/ROCm/pytorch.git",
    "branch": "release/2.7"
  },
  "pytorch_audio": {
    "commit": "95c61b4168fc5133be8dd8c1337d929d066ae6cf",
    "repo": "https://github.com/pytorch/audio"
  },
  "pytorch_vision": {
    "commit": "59a3e1f9f78cfe44cb989877cc6f4ea77c8a75ca",
    "repo": "https://github.com/pytorch/vision"
  },
  "triton": {
    "commit": "95abd4daa02d789ed257178ba35b4ef2d746ca29",
    "repo": "https://github.com/ROCm/triton.git"
  },
  "apex": {
    "commit": "7a57becffa31a4394369152e978fa6f8a0f005c2",
    "repo": "https://github.com/ROCm/apex"
  },
  "therock": {
    "commit": "02024427089134e951fe4063100b93c28e7e01a8",
    "repo": "https://github.com/ROCm/TheRock.git",
    "branch": "users/erman-gurses/add-apex-to-pytorch-manifest"
  }
}

Link: https://therock-dev-artifacts.s3.us-east-2.amazonaws.com/22070943413-linux/manifests/gfx94X-dcgpu/therock-manifest_torch_py3.10_release-2.7.json

Submission Checklist

@marbre
Copy link
Member

marbre commented Feb 16, 2026

@erman-gurses can you either file the sections in the PR description or remove the empty ones?

@erman-gurses
Copy link
Contributor Author

erman-gurses commented Feb 16, 2026

@erman-gurses can you either file the sections in the PR description or remove the empty ones?

@marbre, I will fill out fully after I finish my tests then convert it from draft to a full PR.

@HereThereBeDragons
Copy link
Contributor

just looking at the pytorch build failures we are having in nightlies: could we create the manifest anyway independent if the build succeeds or not? so we have an idea what exactly got checked out? even if it is not all components of torch?

@erman-gurses
Copy link
Contributor Author

just looking at the pytorch build failures we are having in nightlies: could we create the manifest anyway independent if the build succeeds or not? so we have an idea what exactly got checked out? even if it is not all components of torch?

https://github.com/ROCm/TheRock/actions/runs/22070943413/job/63775043033
That is a good point. I generate the manifest file Generate PyTorch Manifest after after Build PyTorch Wheels so for now, we need to finish PyTorch Build successfully. However, this will change in the near future. It should generate the manifest file right after the checkouts. We have ongoing discussion for that.

@erman-gurses erman-gurses marked this pull request as ready for review February 16, 2026 17:56
@ScottTodd ScottTodd requested review from amd-sriram and removed request for ScottTodd February 16, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

3 participants