Organize benchmark test framework files under extended_tests#3427
Open
Organize benchmark test framework files under extended_tests#3427
Conversation
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
geomin12
reviewed
Feb 16, 2026
Contributor
geomin12
left a comment
There was a problem hiding this comment.
looks good, can we add a test to make sure this works properly? a URL of a good run?
ScottTodd
reviewed
Feb 16, 2026
Member
There was a problem hiding this comment.
Drive-by: I don't think these files belong under build_tools/github_actions/ at all. They aren't build tools and they shouldn't be unique to github actions.
Maybe a subfolder under tests/ is more appropriate?
Keeping files that aren't build tools in the build tools directory is making running unit tests unnecessarily complicated, see
TheRock/.github/workflows/unit_tests.yml
Lines 37 to 46 in 70cd41e
TheRock/build_tools/pyproject.toml
Lines 1 to 6 in 70cd41e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is the first part of restructuring the testing infrastructure. It focuses on file organization - moving existing benchmark test files from
benchmarks/toextended_tests/to prepare for a unified test framework that will support both benchmark and functional tests.Technical Details
1. Directory Restructure
Moved:
benchmarks/toextended_tests/benchmark/New structure:
2. Key Changes
File Organization
benchmarks/toextended_tests/benchmark/benchmarks/utils/toextended_tests/utils/(shared across test types)benchmarks/configs/config.ymltoextended_tests/configs/config.yml(shared config)benchmark_client.pytotest_client.py(preparation for shared use)Import Path Updates
fetch_test_configurations.pyconfigure_ci_test.pyDocumentation
extended_tests/README.md: Framework overview with placeholder for functional testsextended_tests/functional/README.md: Placeholder documentation (functional tests to be added in follow-up PR)Test Plan
Testing:
Next Steps
This PR establishes the file structure. Follow-up PRs will: