Add container_image and container_options to components matrix#3426
Add container_image and container_options to components matrix#3426
Conversation
|
This is experimental for now. I've added folks that are likely interested in this change and can chime in about how to do it properly. The change is a step towards allowing components a little wiggle room in deciding how they want their containers setup for testing. This is mostly rocgdb-specific for now given its requirements to have compilers and other tools available to run its tests. Ultimately I have to make rocgdb testing use the new no_rocm extended image (https://github.com/ROCm/TheRock/pkgs/container/no_rocm_image_ubuntu24_04_rocgdb), but I wanted to do it in a clean-ish way. |
lumachad
force-pushed
the
users/lumachad/therock/rocgdb/use_rocgdb_image
branch
2 times, most recently
from
83efafa to
9031232
Compare
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
Looks good to me if it works as intended! ;) In particular, nice that it doesn't touch the default behavior!
geomin12
left a comment
geomin12
left a comment
There was a problem hiding this comment.
lgtm! still waiting on test to make sure this works proper
lumachad
force-pushed
the
users/lumachad/therock/rocgdb/use_rocgdb_image
branch
from
9031232 to
6a382a5
Compare
ROCgdb needs to use a special extended no_rocm image due to its dependencies. To do that cleanly, augment the component matrix to contain a couple new fields: - container_image: A string representing the container image that should be used when setting up tests for this component. - container_options: A string with one or more command lines that should be passed to the container creation when setting up tests for this component. If container_image is not specified, the component will use the default no_rocm image. In this draft I'm using the debug agent as a test component, given we don't yet have rocgdb in the CI.
lumachad
force-pushed
the
users/lumachad/therock/rocgdb/use_rocgdb_image
branch
from
6a382a5 to
c6f8ab6
Compare
3 participants
ROCgdb testing needs to use a special extended no_rocm image due to its dependencies.
To do that cleanly, augment the component matrix to contain a couple new
fields:
used when setting up tests for this component.
passed to the container creation when setting up tests for this component.
If container_image is not specified, the component will use the default no_rocm
image.
In this draft I'm using the debug agent as a test component, given we don't yet
have rocgdb in the CI.