[ci] setup_test_environment.yml s3 removal as no longer used#3395
Merged
[ci] setup_test_environment.yml s3 removal as no longer used#3395
setup_test_environment.yml s3 removal as no longer used#3395Conversation
geomin12
requested review from
amd-justchen,
idass1990,
jayhawk-commits and
jharryma
geomin12
added
the
skip-ci
subodh-dubey-amd
approved these changes
Feb 17, 2026
Contributor
subodh-dubey-amd
left a comment
subodh-dubey-amd
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! LGTM -- verified aws CLI has no remaining usage in test workflows; everything goes through boto3 now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that we still install s3 even though boto3 is the tool used for package retrieval! Saves some time in environment setup, so we are removing s3 installs as it is no longer needed
Succcesful linux test: https://github.com/ROCm/TheRock/actions/runs/21956437410/job/63421818744
Successful windows test: https://github.com/ROCm/TheRock/actions/runs/21956437410/job/63421820914
As this does not require build and the above tests is sufficient for testing, I added
skip-cilabel