Allow building tensilelite-client from TheRock#3390
Open
roberteg16 wants to merge 2 commits intomainfrom
Open
Conversation
added 2 commits
February 12, 2026 06:22
This is requirement in order to be able to build tensilelite-client from hipblaslt from TheRock super repo.
This is a requirement to be able to build hipblastlt-client from TheRock super project.
marbre
reviewed
Feb 12, 2026
Member
marbre
left a comment
There was a problem hiding this comment.
Adding additional deps on Boost needs more explanation as there is the demand to rip it out in the longer term.
| BUILD_DEPS | ||
| hipBLAS-common | ||
| rocm-cmake | ||
| therock-boost |
Member
There was a problem hiding this comment.
Is Boost needed explicitly to build tensilelite-client or why is this added here? It's a highly undesired dep..
Author
There was a problem hiding this comment.
These are the errors I get if I do not explicitly declare the dependency for hipSPARSELt and hipBLASLt:
(This one is specificly for hipSPARSELt)
[hipSPARSELt configure] CMake Error at /scratch/repos/TheRock/cmake/therock_subproject_dep_provider.cmake:64 (message):
[hipSPARSELt configure] Project contains find_package(Boost) for a package availabe in the
[hipSPARSELt configure] super-project but not declared: Add a BUILD_DEPS or RUNTIME_DEPS
[hipSPARSELt configure] appropriately
[hipSPARSELt configure] Call Stack (most recent call first):
[hipSPARSELt configure] /scratch/repos/TheRock/rocm-libraries/projects/hipblaslt/tensilelite/client/CMakeLists.txt:4 (find_package)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Needed to build tensilite-client to do tuning on a specific architecture and iterate over a few changes to the source code. When trying to enable the binary like so:
Found several problems that I fix in this PR.
Technical Details
Also add program_options boost package and add therock-boost dependency to hipBLASLt and hipSPARSELt.
Test Plan
Build needs to pass.
Test Result
Build passed.
Submission Checklist