Skip to content

Allow building tensilelite-client from TheRock#3390

Open
roberteg16 wants to merge 2 commits intomainfrom
users/rogarcia/allow_building_tensilelite_client_from_TheRock
Open

Allow building tensilelite-client from TheRock#3390
roberteg16 wants to merge 2 commits intomainfrom
users/rogarcia/allow_building_tensilelite_client_from_TheRock

Conversation

@roberteg16
Copy link

Motivation

Needed to build tensilite-client to do tuning on a specific architecture and iterate over a few changes to the source code. When trying to enable the binary like so:

diff --git a/projects/hipblaslt/CMakeLists.txt b/projects/hipblaslt/CMakeLists.txt
index 55b2c0e0c8..bbcd41a5c6 100644
--- a/projects/hipblaslt/CMakeLists.txt
+++ b/projects/hipblaslt/CMakeLists.txt
@@ -59,7 +59,7 @@ option(HIPBLASLT_ENABLE_THEROCK "Build hipBLASLt for TheRock." OFF)
 
 option(TENSILELITE_ENABLE_HOST "Build the tensilelite host library." ON)
 option(TENSILELITE_BUILD_TESTING "Build client when building tests" OFF)
-option(TENSILELITE_ENABLE_CLIENT "Build tensilelite client" ${TENSILELITE_BUILD_TESTING})
+option(TENSILELITE_ENABLE_CLIENT "Build tensilelite client" ON)
 option(TENSILELITE_ENABLE_AUTOBUILD "Generate scripts for wrapping tensile python scripts" OFF)
 
 if(HIPBLASLT_ENABLE_CLIENT)

Found several problems that I fix in this PR.

Technical Details

Also add program_options boost package and add therock-boost dependency to hipBLASLt and hipSPARSELt.

Test Plan

Build needs to pass.

Test Result

Build passed.

Submission Checklist

Robert Esclapez-Garcia added 2 commits February 12, 2026 06:22
This is requirement in order to be able to build tensilelite-client from
hipblaslt from TheRock super repo.
This is a requirement to be able to build hipblastlt-client from TheRock
super project.
Copy link
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding additional deps on Boost needs more explanation as there is the demand to rip it out in the longer term.

BUILD_DEPS
hipBLAS-common
rocm-cmake
therock-boost
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Boost needed explicitly to build tensilelite-client or why is this added here? It's a highly undesired dep..

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the errors I get if I do not explicitly declare the dependency for hipSPARSELt and hipBLASLt:

(This one is specificly for hipSPARSELt)

[hipSPARSELt configure] CMake Error at /scratch/repos/TheRock/cmake/therock_subproject_dep_provider.cmake:64 (message):
[hipSPARSELt configure]   Project contains find_package(Boost) for a package availabe in the
[hipSPARSELt configure]   super-project but not declared: Add a BUILD_DEPS or RUNTIME_DEPS
[hipSPARSELt configure]   appropriately
[hipSPARSELt configure] Call Stack (most recent call first):
[hipSPARSELt configure]   /scratch/repos/TheRock/rocm-libraries/projects/hipblaslt/tensilelite/client/CMakeLists.txt:4 (find_package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants