[CI] Add CK (independent of miopen) full build and run a single sample test to TheRock#3382
[CI] Add CK (independent of miopen) full build and run a single sample test to TheRock#3382brockhargreaves-amd wants to merge 15 commits intomainfrom
Conversation
brockhargreaves-amd
added
the
test:composablekernel
brockhargreaves-amd
changed the title
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
| cmd = [ | ||
| "test_ck_tile_pooling", |
There was a problem hiding this comment.
just curious, is this the only test that CK runs?
There was a problem hiding this comment.
It will not be the only test that runs. @illsilin recommended we run the following after compiling:
"make smoke"
Which would build and run the smoke tests. However, this would require bundling the source code for the test into the artifact as well, no? If this is an easy thing to add, I'm happy to do it. But I don't think we should strive for perfect on the first PR. Oh I suppose the alternative is to just build the smoke tests as part of the build step....sorry my brain is a bit fried right now.
We're going to require more PR's later for filtering anyways, picking and choosing the appropriate tests, and striving to keep our build and runtimes short. What I want to see before we do that, is an end to end CI of CK on Strix Halo architecture, particularly for Windows.
| "composablekernel": { | ||
| "job_name": "composablekernel", | ||
| "fetch_artifact_args": "--composablekernel --tests", | ||
| "timeout_minutes": 60, |
There was a problem hiding this comment.
i think you mentioned compilation takes ~ 40 mins. Is the compilation done in the test itself?
There was a problem hiding this comment.
It compiled with 144 cores on an Alola node in about 48 minutes which included the unit tests. This does not include building the smoke tests.
There was a problem hiding this comment.
Once we see how long the build is taking on TheRock, we can decide if this is going to be too disruptive. If it is, then we could consider making it a nightly. I'd rather see it run once a day completely than not at all (our current situation) or timing out.
| "composablekernel": { | ||
| "job_name": "composablekernel", | ||
| "fetch_artifact_args": "--composablekernel --tests", | ||
| "timeout_minutes": 60, |
There was a problem hiding this comment.
60 mins is also a long time.... are there any smoke test filters for the test? for non-build related changes, we want a test set that runs in ~ 5 mins to provide sanity
There was a problem hiding this comment.
Sorry it wasn't clear to me in the script whether or not the timeout applied to the compilation or to the test run. Is this timeout for both or for just one?
|
Hey @geomin12
|
2 participants
Motivation
We currently only have a narrow build (small collection necessary for building miopen) of CK running on TheRock. We want a full build and testing here.
Technical Details
Changes were made to various CMake files, build topology, etc.
Test Plan
Testing done locally and waiting on CI.
Test Result
Waiting on CI.
Submission Checklist