Skip to content

[torch] Re-enable now passing test_cudnn_rnn_dropout_states_device#3367

Open
k-artem wants to merge 1 commit intomainfrom
revert_skip_of_pytorch_tests
Open

[torch] Re-enable now passing test_cudnn_rnn_dropout_states_device#3367
k-artem wants to merge 1 commit intomainfrom
revert_skip_of_pytorch_tests

Conversation

@k-artem
Copy link
Contributor

@k-artem k-artem commented Feb 11, 2026

Original issue: #2120
Fix: ROCm/rocm-libraries#4007

Motivation

Enable pytorch testcases which were skipped due to miopen's compilation issue -> #2120

Technical Details

Remove from lists for skip

Test Plan

PYTORCH_TEST_WITH_ROCM=1 python test/test_nn.py TestNN.test_cudnn_rnn_dropout_states_device

Test Result

(therock_venv) root@RSB-RORLAB-17-L:~/test_therock/pytorch# PYTORCH_TEST_WITH_ROCM=1 python test/test_nn.py TestNN.test_cudnn_rnn_dropout_states_device
.
----------------------------------------------------------------------
Ran 1 test in 0.655s

OK

Compilation log:
compile.log

Submission Checklist

@k-artem k-artem requested a review from ScottTodd February 11, 2026 10:27
@ScottTodd ScottTodd changed the title Update lists of skipped pytroch tests [torch] Re-enable now passing test_cudnn_rnn_dropout_states_device Feb 11, 2026
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for future PRs please follow the branch naming conventions: https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md#branch-creation-and-naming (add users/USERNAME/ prefix). We're up to almost 550 branches in the shared repository and I'd be more comfortable with closer to 200 branches. Tagging branches with usernames will help clean up stale branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

2 participants