Draft
Conversation
Refactor AWS upload functions to include retry logic for robustness. Update function signatures to accept max_retries parameter.
ScottTodd
reviewed
Feb 11, 2026
Comment on lines
+59
to
+65
| def run_aws_command(cmd: list[str], cwd: Path, max_retries: int): | ||
| base_delay_seconds = 2 | ||
| for attempt in range(max_retries): | ||
| try: | ||
| log(f"++ Exec [{cwd}]$ {shlex.join(cmd)}") | ||
| subprocess.run(cmd, check=True) | ||
| return |
Member
There was a problem hiding this comment.
These files are due to be migrated to the AWS SDK for Python (boto3) instead of using the AWS CLI tool. We should use the retry functionality that boto3 provides:
Contributor
There was a problem hiding this comment.
Should we create two separate PRs for this work?
- Migrate all files to use the AWS SDK for Python (boto3) instead of relying on the AWS CLI (also there are
aws s3 cpcommands in the GitHub Actions workflow). - Implement retry logic using the AWS SDK for Python (boto3).
Member
There was a problem hiding this comment.
Migrating "all files" in one step may be a stretch, that could be multiple PRs depending on complexity, but yes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor AWS upload functions to include retry logic for robustness. Update function signatures to accept max_retries parameter.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist