Fixes bug in one specialized HIP instantiation of the warp-per-row kernel#134
Open
aryaman-gupta wants to merge 2 commits intomain_12052025_upstreamfrom
Open
Fixes bug in one specialized HIP instantiation of the warp-per-row kernel#134aryaman-gupta wants to merge 2 commits intomain_12052025_upstreamfrom
warp-per-row kernel#134aryaman-gupta wants to merge 2 commits intomain_12052025_upstreamfrom
Conversation
…n for D=320, half
liligwu
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specialized
load_row_per_warpfunction for the case:emb_t = halfandembedding_dim=320contained a bug in the pointer arithmetic. This PR fixes it.The fix is a change in a single line of code in the
fbgemm_gpu/include/fbgemm_gpu/rocm/split_embeddings_common.hfile.