Open
Conversation
added packing L optimization
packed bag L optimization
added packedMode_L optimization
avbokovoy
requested changes
Apr 23, 2025
avbokovoy
left a comment
avbokovoy
left a comment
There was a problem hiding this comment.
The issues I see so far:
- It fails to pass tests
- Seems like not all issues with history are yet solved
- Some dead code that shouldn't go into upstream
- Copy-paste
Still continue the review on main algorithm
fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_inference.py
Outdated
Show resolved
Hide resolved
fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_inference.py
Outdated
Show resolved
Hide resolved
fbgemm_gpu/codegen/inference/embedding_forward_quantized_split_nbit_kernel_template.cu
Outdated
Show resolved
Hide resolved
fbgemm_gpu/codegen/inference/embedding_forward_quantized_split_nbit_kernel_template.cu
Outdated
Show resolved
Hide resolved
fbgemm_gpu/codegen/inference/embedding_forward_quantized_split_nbit_kernel_template.cu
Outdated
Show resolved
Hide resolved
| {% if not nobag %} | ||
| VecNT<{{ (32 // emb_weight_type.bit_width) }}, PrimitiveType::{{ emb_weight_type.primitive_type }}> accumulators[OutputRowsPerThread][AccumulateStoreRequests]; | ||
| {% endif %} | ||
| if constexpr (PackedMode_L){ |
There was a problem hiding this comment.
Can we avoid copy-pasting and embed your algorithm?
Author
There was a problem hiding this comment.
This one might be hard because some for loops are fused together (input_row_in_flights+packedBagL) so we might end up having 2 if else condition still but on a later line of the code instead.
fbgemm_gpu/codegen/inference/embedding_forward_quantized_split_nbit_kernel_template.cu
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.