dkms module shouldn't be installed in version higher than 18.10#16
Open
hyc3z wants to merge 1 commit intoROCm:masterfrom
Open
dkms module shouldn't be installed in version higher than 18.10#16hyc3z wants to merge 1 commit intoROCm:masterfrom
hyc3z wants to merge 1 commit intoROCm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ubuntu LTS 18.10.2 the script will fail due to string comparison between "18.10.2" and "18.10" will return false, and rocm-dkms will be installed, however the module will fail to build with kernel 4.18. So I am thinking, whether we can set the if statement to kernel version comparison? But I don't know what exact version of kernel starts to fail. This could be a temporary fix for Ubuntu distros.